> On 2010-11-11 10:19:55, Kannan Muthukkaruppan wrote: > > Jonathan: Yes-- only Nicolas' change impacts this at the moment. With > > Amitanand's change I was confused about the per column family flushes and > > compactions stuff that he had started to look at. So agree that his earlier > > change (unifying major/minor) doesn't affect this. > > > > Haven't reviewed your new diff yet-- but question based on your > > description. If you are going to now use the per Store's file timestamp of > > any major compacted files it has, then why do we still need the region > > level .lastmajor file?
The .lastmajor file is there because it is the fix to HBASE-2990. There can be times where there is no major compacted file on disk for a Store, that doesn't mean a major compaction was not done at some time. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1089/#review1914 ----------------------------------------------------------- On 2010-11-11 09:53:02, Jonathan Gray wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1089/ > ----------------------------------------------------------- > > (Updated 2010-11-11 09:53:02) > > > Review request for hbase, stack and khemani. > > > Summary > ------- > > This is a somewhat misguided attempt. It's not done but it shows the fairly > simple change to the actual major compaction code. > > The hard part is: > > + long lastMajor = region.getRegionInfo().getRegionData().getLastMajor(); > > And the question is where to persist that. > > This patch adds a new class called HRegionData into HRegionInfo that contains > any number of key-value pairs of data that get persisted with the HRI. Not > really sure how I ended up there but this data seemed like an odd-man-out so > adding another field seemed weird. We also need some kind of versioning in > HRI so we can add stuff w/o migrating. There's some versioned stuff in > HRData. > > Just looking for some feedback / ideas. > > > This addresses bugs HBASE-2990 and HBASE-3083. > http://issues.apache.org/jira/browse/HBASE-2990 > http://issues.apache.org/jira/browse/HBASE-3083 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > 1034008 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1034008 > > Diff: http://review.cloudera.org/r/1089/diff > > > Testing > ------- > > > Thanks, > > Jonathan > >
