----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1252/ -----------------------------------------------------------
Review request for hbase, Jonathan Gray and Kannan Muthukkaruppan. Summary ------- This is a design change suggested in HBASE-3276 so adequate thought should be given before proceeding. The main code change is just one line which is to ignore key type while doing KV comparisons. When the key type is ignored, then all the keys for the same timestamp are sorted according the order in which they were interested. It is still ensured that the delete family and delete column will be at the top because they have the default column name and default timestamp. This addresses bug HBASE-3276. http://issues.apache.org/jira/browse/HBASE-3276 Diffs ----- trunk/src/main/java/org/apache/hadoop/hbase/KeyValue.java 1039233 trunk/src/test/java/org/apache/hadoop/hbase/regionserver/KeyValueScanFixture.java 1039233 trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java 1039233 Diff: http://review.cloudera.org/r/1252/diff Testing ------- Test cases added. Since there is a change in semantics, some previous tests were failing because of this change. Those tests have been modified to test the newer behavior. Thanks, Pranav