-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1298/
-----------------------------------------------------------

(Updated 2010-12-16 17:01:04.757304)


Review request for hbase and Jonathan Gray.


Changes
-------

I implemented Jon's suggestions and then some.  Not pretty but works in my 
local and cluster testing.


Summary
-------

M 
src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
 Removed stale comments and TODOs.

 Added a 'version' datamenber, the znode edit version which we keep across open 
process.

 Refactored the setting of OPENING out into a method that is used in multiple 
places 
 now rather than repeat code.  Did this in new tickleOpening method.

 Added new PostOpenDeployTasksThread which we run to do the postOpenDeployTasks.
 While its running we update OPENING state if its running a while.


This addresses bug hbase-3362.
    http://issues.apache.org/jira/browse/hbase-3362


Diffs (updated)
-----

  
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
 1050086 

Diff: http://review.cloudera.org/r/1298/diff


Testing
-------

Ran it on my cluster. Seems to work as the old code did.


Thanks,

stack

Reply via email to