----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1298/#review2103 -----------------------------------------------------------
Ship it! it's getting pretty crazy but this looks good. it's unfortunate we have all these extra node transitioning methods inside this class. this pattern of doing node transitions and tracking expected version is very common and we'll probably have more of it so we should look at doing some kind of generic abstraction for that pattern soon. +1 for commit, thanks for the changes trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java <http://review.cloudera.org/r/1298/#comment6561> typo 'initalizes' but good comment trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java <http://review.cloudera.org/r/1298/#comment6562> interesting thing is... we only use this progressable if we do a log replay. in that case, a region open is not really idempotent as we treat it here. outside scope of this jira but something to think about. - Jonathan On 2010-12-16 17:01:04, stack wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1298/ > ----------------------------------------------------------- > > (Updated 2010-12-16 17:01:04) > > > Review request for hbase and Jonathan Gray. > > > Summary > ------- > > M > src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java > Removed stale comments and TODOs. > > Added a 'version' datamenber, the znode edit version which we keep across > open process. > > Refactored the setting of OPENING out into a method that is used in multiple > places > now rather than repeat code. Did this in new tickleOpening method. > > Added new PostOpenDeployTasksThread which we run to do the > postOpenDeployTasks. > While its running we update OPENING state if its running a while. > > > This addresses bug hbase-3362. > http://issues.apache.org/jira/browse/hbase-3362 > > > Diffs > ----- > > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java > 1050086 > > Diff: http://review.cloudera.org/r/1298/diff > > > Testing > ------- > > Ran it on my cluster. Seems to work as the old code did. > > > Thanks, > > stack > >
