+1 to the idea of putting it in. I'm going to try to do a code review tonight. If we could hold off a day or so to commit I'd appreciate it... but if other stuff is blocked on it, go ahead whenever IMO.
On Tue, Jul 26, 2011 at 11:25 PM, Nicolas Spiegelberg <[email protected]>wrote: > +1 for 0.92. This has received a lot of testing and code review internally. > We have already found/fixed a number of advanced bugs before even submitting > the initial patch. Very high quality. > > On Jul 26, 2011, at 7:18 PM, "Stack" <[email protected]> wrote: > > > Shall we commit the patch at > > https://issues.apache.org/jira/browse/HBASE-3857 for 0.92? > > > > I reviewed it and its high-quality, with lots of new tests, and an > > attention to self-migration (which it does) that is heartening. > > > > I'm +1 on committing it now to TRUNK in time for 0.92 before this fat > > patch rots our on JIRA. > > > > What you lot think? > > > > St.Ack > -- Todd Lipcon Software Engineer, Cloudera
