I always do that, unless I contributed the change myself, in which case I assume it is implied that the change is mine. Did somebody not do that? That would be bad (IMHO)
-- Lars ----- Original Message ----- From: Andrew Purtell <[email protected]> To: "[email protected]" <[email protected]> Cc: Sent: Monday, January 20, 2014 4:36 PM Subject: Are we no longer giving credit in SVN commit messages? I see some committers are continuing the informal practice we've had of attribution in parenthesis after the issue description if the work is not your own, e.g. HBASE-XXXX. JIRA title goes here (Contributor Name) I've noticed that some committers are definitely not doing this. I think it is bad practice not to provide attribution to the contributor in the commit message. When one is reviewing commit history, neither links to JIRA nor inlining of JIRA content is possible -- unless there is some tool that does this of which I'm not aware (please let me know!). -- Best regards, - Andy Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)
