So just to confirm we're agreeing to follow the following format. HBASE-xxxxx <title>. (<contributor>)
What do people do about their own contributions? I have not bothered with tagged my own patches with "(LarsH)". -- Lars ----- Original Message ----- From: Jonathan Hsieh <[email protected]> To: "[email protected]" <[email protected]> Cc: Sent: Monday, January 20, 2014 4:46 PM Subject: Re: Are we no longer giving credit in SVN commit messages? +1 to andrews format HBASE-xxxxx JIRA Title (contributor name) One nit is most of our jiras are committed without the '.' after the jira name. Not the end of the world if a '.' or ':' sneaks in. Jon On Mon, Jan 20, 2014 at 4:36 PM, Andrew Purtell <[email protected]> wrote: > I see some committers are continuing the informal practice we've had of > attribution in parenthesis after the issue description if the work is not > your own, e.g. > > HBASE-XXXX. JIRA title goes here (Contributor Name) > > I've noticed that some committers are definitely not doing this. > > I think it is bad practice not to provide attribution to the contributor in > the commit message. When one is reviewing commit history, neither links to > JIRA nor inlining of JIRA content is possible -- unless there is some tool > that does this of which I'm not aware (please let me know!). > > -- > Best regards, > > - Andy > > Problems worthy of attack prove their worth by hitting back. - Piet Hein > (via Tom White) > -- // Jonathan Hsieh (shay) // Software Engineer, Cloudera // [email protected]
