Hum.... the API is different today, and will remain different after
HBASE-10422.
https://github.com/apache/hbase/blob/trunk/hbase-protocol/src/main/java/com/google/protobuf/ZeroCopyLiteralByteString.java
has: public static ByteString wrap(final byte[] array, int offset, int
length) {
And this method is not in
https://github.com/tsuna/asynchbase/blob/master/src/protobuf/ZeroCopyLiteralByteString.java
It's too brittle. I created HBASE-10431 for this.
On Mon, Jan 27, 2014 at 5:35 PM, tsuna <[email protected]> wrote:
> On Mon, Jan 27, 2014 at 1:02 AM, Nicolas Liochon <[email protected]>
> wrote:
> > Should we not rename ZeroCopyLiteralByteString to something like
> > HBasePrivateZeroCopyLiteralByteString to be sure that we won't have name
> > conflicts in the future?
>
> I don't mind keeping the same name as long as we agree on the API.
> I don't expect this class to change much if at all anyway. It's just
> really unfortunate that this method was changed, what's more with a
> signature that renders it unusable.
>
> --
> Benoit "tsuna" Sigoure
>
