Yeah. I messed up not adding '--signoff'. St.Ack
On Fri, Aug 1, 2014 at 10:43 AM, Andrew Purtell <[email protected]> wrote: > I noticed that commit and just sent something to private@ :-) I think it's > a fine practice, but there is no sign off line on that commit so the > committer is not apparent. As long as we can know who committed the patch > at a glance it sounds good to me. > > > On Fri, Aug 1, 2014 at 10:38 AM, Stack <[email protected]> wrote: > > > I just committed a message with 'git am' because the author took the > > trouble to write a sweet commit message. Others have been taking the > > trouble to write useful commit messages but up to this I've been just > > applying patches with patch with a commit message that is the issue > number, > > subject, and author only rather than git apply or git am. > > > > On the tail of HBASE-4593, Misty is looking for clarification. > > > > I suggest that if contributor wrote a nice commit message that leads off > > with issue number and issue subject, going forward, we preserve their > work > > and apply using git am --signoff? > > > > You cowboys and cowgirls have any opinions? > > St.Ack > > > > > > -- > Best regards, > > - Andy > > Problems worthy of attack prove their worth by hitting back. - Piet Hein > (via Tom White) >
