the version is hbase0.98.10, find some improvements on snapshot:
1. in class SnapshotManager, line 725, we make a clone of HTableDescriptor,  
the clone is not so need to make
2 class HBaseAdmin, method   
    public void restoreSnapshot(final String snapshotName, boolean 
takeFailSafeSnapshot)
{
    TableName tableName = null;
    for (SnapshotDescription snapshotInfo: listSnapshots()) {
      if (snapshotInfo.getName().equals(snapshotName)) {
        tableName = TableName.valueOf(snapshotInfo.getTable());
        break;
      }
    }
......
}
  must get all snapshot from master and then get the one we need, can improve 
this, master just return the snapshot client needed


3. there should better has a method 'isSnapShotExists' in HBaseAdmin







Reply via email to