For #1, I took a look at current 0.98 code but didn't find it. Can you double check and tell us the updated line number ?
For #2, I think it makes sense - considering there may be large number of snapshots in the cluster. For #3, can you tell us the use case for the new API ? Cheers On Fri, Nov 6, 2015 at 10:12 PM, 王勇强 <[email protected]> wrote: > the version is hbase0.98.10, find some improvements on snapshot: > 1. in class SnapshotManager, line 725, we make a clone of > HTableDescriptor, the clone is not so need to make > 2 class HBaseAdmin, method > public void restoreSnapshot(final String snapshotName, boolean > takeFailSafeSnapshot) > { > TableName tableName = null; > for (SnapshotDescription snapshotInfo: listSnapshots()) { > if (snapshotInfo.getName().equals(snapshotName)) { > tableName = TableName.valueOf(snapshotInfo.getTable()); > break; > } > } > ...... > } > must get all snapshot from master and then get the one we need, can > improve this, master just return the snapshot client needed > > > 3. there should better has a method 'isSnapShotExists' in HBaseAdmin > > > > > > > >
