Appy, would you consider doing the work of trying to upstream this to Apache Yetus? The precommit component of that project already has the excellent "smart-apply-patch", which uses the precommit system's notion of project configs to easily allow me to locally evaluate a patch just given a jira id. I'd love it if that same toolset allowed me to easily perform the other side of that interaction when I'm contributing.
On Thu, May 26, 2016 at 9:26 AM, Stack <st...@duboce.net> wrote: > This is excellent Appy. I pushed HBASE-15892. > Thanks, > St. > > On Thu, May 26, 2016 at 8:48 AM, Apekshit Sharma <a...@cloudera.com> wrote: > >> Run this first : pip install gitpython && pip install rbtools >> >> >> >> On Thu, May 26, 2016 at 7:51 AM, Apekshit Sharma <a...@cloudera.com> >> wrote: >> >> > Hi folks >> > >> > Ref: https://issues.apache.org/jira/browse/HBASE-15892 >> > >> > The script does the following: >> > - makes the patch (next version is determined by existing attachments in >> > the jira) >> > - Updates the review on RB. If review doesn't already exists, creates a >> > new one and adds the link to the jira >> > - Attaches the new patch to the jira >> > >> > For quite sometime, I have been thinking that we should be using Review >> > Board more for reviews. Even though review board has so many benefits, we >> > don't use it enough because of the painful process of setting up a new >> > review request and updating it every time through web UI. >> > But I really like the following things which come with RB, >> > - being able to comment in-place (instead of quoting codes in jira >> > comments) >> > - the fact that comments are strung together and give better context of >> > past >> > - being able to tracks open reviews >> > - easy to see who reviewed/+1ed >> > - and my personal favorite, easy to see incremental changes >> > >> > Give it a shot, and post any errors encountered on the same jira. >> > >> > Thanks, >> > -- Appy >> > >> >> >> >> -- >> >> Regards >> >> Apekshit Sharma | Software Engineer, Cloudera | Palo Alto, California | >> 650-963-6311 >> -- busbey
