Hi Am confused why do we have this weird circular dependency between the two modules: hbase-metrics-api & hbase-metrics. And since maven doesn't allow it explicitly, this was tucked and hidden by using reflection?
MetricRegistriesImpl[hbase-metrics] implements MetricRegistries[hbase-metrics-api]. MetricRegistriesLoader[hbase-metrics-api] depends on this implementation, MetricRegistriesImpl, because it instantiates it via reflection <https://github.com/apache/hbase/blob/eee3b0180ead73c09b33f9583bfee9c01bc3aed2/hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java#L39> [1]. Can we just move all interfaces and default implementation together into single module. But i like the idea of keeping implementations in separate package with "impl" explicitly in package name. [1] https://github.com/apache/hbase/blob/eee3b0180ead73c09b33f9583bfee9c01bc3aed2/hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java#L39 -- Appy
