It is not my practice to sign commits or tags. Is this mandatory? It could be. Was there an announcement or discussion? I didn’t see it.
Thanks for taking a look! Please set a fix version of 1.4.4 for the html file issues so they get looked at next time. > On Mar 30, 2018, at 10:47 PM, Sean Busbey <[email protected]> wrote: > > +1 (binding) > > Good: > > * checksums and signatures in dist.a.o match up > * source artifact matches with ref 172373d1f0 > * compat report looks good > * LICENSE/NOTICE look fine > * rat looks good (couple of things noted below) > > Bad but not a blocker: > > * tag is not signed, presumably the release tag will be? > > * HBASE-20276 "[shell] confirm shell REPL change and document" > describes a change that's present on branch-1.4 that I think is a > critical bug. Since it's been present since 1.4.0 I don't think it > needs to sink this RC, but I would prefer not moving the "stable > release" pointer until we've decided on a fix. > > * book.html and javadocs in the binary tarball doesn't have license > info in it. neither does the live website's version so I don't think > it's an issue specific to the release. > > * there are a few other unlicensed HTML files that look to be spurious > or out of date (e.g. docs/integration.html). they're the same on the > live website, so not something to block this release. But I'll file a > JIRA to get them updated and/or removed. > >> On Fri, Mar 23, 2018 at 7:09 PM, Andrew Purtell <[email protected]> wrote: >> The first HBase 1.4.3 release candidate (RC0) is available for download at >> https://dist.apache.org/repos/dist/dev/hbase/hbase-1.4.3RC0/ and Maven >> artifacts are available in the temporary repository >> https://repository.apache.org/content/repositories/orgapachehbase-1207/ . >> >> The git tag corresponding to the candidate is '1.4.3RC0' (172373d1f0). >> >> A detailed source and binary compatibility report for this release is >> available for your review at >> https://dist.apache.org/repos/dist/dev/hbase/hbase-1.4.3RC0/compat-check-report.html >> . >> >> A list of the 36 issues resolved in this release can be found at >> https://s.apache.org/FM08 . >> >> Please try out the candidate and vote +1/0/-1. >> >> This vote will be open for at least 72 hours. Unless objection I will try >> to close it Friday March 30, 2018 if we have sufficient votes. >> >> Prior to making this announcement I made the following preflight checks: >> >> RAT check passes (7u80) >> Unit test suite passes (7u80) >> LTT load 1M rows with 100% verification and 20% updates (8u152) >> ITBLL Loop 1 1B rows (8u152) >> >> >> -- >> Best regards, >> Andrew
