> Ah, so maybe this is just YETUS-628 "Class level InterfaceAudience is > not applied to internal classes/enums" ?
I didn't trace YETUS-628. But, ya the concept of YETUS-628 is same to me. Nevertheless, seems our docs haven't mentioned the such definition to nested class. If we can reach the consensus on the new rule, it is worth putting it in hbase docs. > is it worth reopening HBASE-18702 and making it a top level issue, or > should I just open a new issue? Open a new issue. Let the old issue go. > How about a "getCellBuilder" or "getCellBuilderFactory" method for > Mutation implementations that gives you a CellBuilder instance that > already has relevant parts set? Like for a Put instance it should be > able to already have the Type and Row set. Good point! +1 > At a minimum the examples in the reference guide need to use > "addColumn" method instead of referring to an "add" method that no > longer exists. It would also be nice if there was at least one example > that used the Cell API instead of a bunch of byte arrays. > > Probably it'd be good to also update the javadocs for the methods that > take a Cell to give a pointer to something about how to make Cells. LGTM. +1 Thanks for making Cell APIs more graceful and useful!!! -- chia-ping On 2018/05/22 13:16:45, Sean Busbey <[email protected]> wrote: > On Tue, May 22, 2018 at 7:44 AM, Chia-Ping Tsai <[email protected]> wrote: > >>the Cell.Type enum is IA.Private > > > > Cell.Type should be IA.Public. I planed to add the IA.Public to Cell.Type > > in HBASE-20121 but I assume the nested class should have the same IA with > > the root class...Perhaps we can file a jira to fix it. > > > > Ah, so maybe this is just YETUS-628 "Class level InterfaceAudience is > not applied to internal classes/enums" ? > > > >> Before I go to update the docs, > > > > There was a related issue (HBASE-18702) although I make it stale.. > > > > is it worth reopening HBASE-18702 and making it a top level issue, or > should I just open a new issue? > > > >> If Cell is fine to use, could we update this to be less repetitive? > > > > The CellBuilder is designed to help folks to use the Put#add(Cell), > > Delete#add(Cell), Increment#add(Cell), and Append#add(Cell) since HBase > > doesn't supply the IA.Public implementation of Cell. > > > > How about a "getCellBuilder" or "getCellBuilderFactory" method for > Mutation implementations that gives you a CellBuilder instance that > already has relevant parts set? Like for a Put instance it should be > able to already have the Type and Row set. > > > And pardon me, what stuff you plan to update? > > At a minimum the examples in the reference guide need to use > "addColumn" method instead of referring to an "add" method that no > longer exists. It would also be nice if there was at least one example > that used the Cell API instead of a bunch of byte arrays. > > Probably it'd be good to also update the javadocs for the methods that > take a Cell to give a pointer to something about how to make Cells. >
