Anyway I'm +1 on moving thrift and rest out to a separated repo. But I think the difficulty here is that, we need to cleanup the dependencies first, and also make sure that these modules do not use the classes other than IA.Public. Otherwise they will easily be broken...
2018-07-24 8:47 GMT+08:00 Stack <[email protected]>: > (Thanks for the good discussion) > > Where we think 'outside of HBase' would be? > > Github seems too 'remote' from project and from Apache? Would we make a new > repo called hbase-connectors and move REST, thrift, and this new patch > there? > > Thanks, > S > > On Mon, Jul 23, 2018 at 3:50 PM Josh Elser <[email protected]> wrote: > > > I'm -0 for including this into the main hbase tree. I feel like we've > > made a bit of progress in cleaning up our core, and this strikes me as a > > step in the wrong direction. > > > > At the same time, the integration seems nice enough (for the same > > reasons Andrew points out). Is there a reason this couldn't exist > > outside of HBase (at the ASF or otherwise)? Given a quick glance at the > > patch, it would be quite trivial to keep separate (just requires some > > heavier scripting to get it off the ground that the HBase scripts do > > setup for). I feel like that will decrease our debt while we see if > > people start using it. Our API should be more than stable enough to > > prevent any worry about drift happening from core to this project. > > > > On 7/23/18 6:35 PM, Stack wrote: > > > We have a very nice contrib sitting up in HBASE-15320 which via a proxy > > -- > > > so minimal dependencies -- adds source and sink for Kafka Connect. It > is > > > nicely contained inside two new hbase-kafka-* modules. > > > > > > We good w/ taking on this new feature? > > > > > > It looks good to me. Check it out up on HBASE-15320. I was going to > > commit > > > to tip of branch-2 so it'd show up in hbase-2.2.x unless you all want > > some > > > backporting action going on. > > > > > > S > > > > > >
