Like I said on the JIRA I’d approve a patch that splits the canary API we need from a tool chassis. We have used and contributed to Canary for a long time and changing the annotation was simply acknowledging our use and continued contribution to this code. We can also just copy Canary into our monitoring tool suite and fork it but prefer to continue contributing canary improvements to open source.
> On Aug 18, 2019, at 6:03 AM, 张铎(Duo Zhang) <palomino...@gmail.com> wrote: > > Due to HBASE-22823 I plan to sink this RC and find a way to deal with the > IA.Public Canary. > > OpenInx <open...@gmail.com> 于2019年8月18日周日 下午4:09写道： > >> See the previous failed UT, it says address already bind. And run the UT >> several times under a new host again, >> seems all works fine. So +1. >> >>> On Sun, Aug 18, 2019 at 3:56 PM OpenInx <open...@gmail.com> wrote: >>> >>> Let me try the TestJMXConnectorServer locally again, although it failed >>> now, it should not effect the rc vote. >>> Give my +1, will take a look about that UT. >>> >>>> On Sun, Aug 18, 2019 at 3:15 PM OpenInx <open...@gmail.com> wrote: >>>> >>>> >>>> * Signature: ok >>>> * Checksum : ok >>>> * Rat check (1.8.0_202): ok >>>> - mvn clean apache-rat:check >>>> * Built from source (1.8.0_202): ok >>>> - mvn clean install -DskipTests >>>> * Unit tests pass (1.8.0_202): failed >>>> - mvn test -P runAllTests >>>> >>>> The failed UT are: >>>> >>>> [INFO] >>>> [ERROR] Errors: >>>> [ERROR] >>>> >> org.apache.hadoop.hbase.TestJMXConnectorServer.testHMConnectorServerWhenShutdownCluster(org.apache.hadoop.hbase.TestJMXConnectorServer) >>>> [ERROR] Run 1: >>>> TestJMXConnectorServer.testHMConnectorServerWhenShutdownCluster:154 » IO >>>> Shutt... >>>> [ERROR] Run 2: TestJMXConnectorServer.tearDown:73 NullPointer >>>> [INFO] >>>> [ERROR] >>>> >> org.apache.hadoop.hbase.TestJMXConnectorServer.testHMConnectorServerWhenStopMaster(org.apache.hadoop.hbase.TestJMXConnectorServer) >>>> [ERROR] Run 1: >>>> TestJMXConnectorServer.testHMConnectorServerWhenStopMaster:85 » IO >> Shutting >>>> do... >>>> [ERROR] Run 2: TestJMXConnectorServer.tearDown:73 NullPointer >>>> [INFO] >>>> [ERROR] >>>> >> org.apache.hadoop.hbase.TestJMXConnectorServer.testRSConnectorServerWhenStopRegionServer(org.apache.hadoop.hbase.TestJMXConnectorServer) >>>> [ERROR] Run 1: >>>> TestJMXConnectorServer.testRSConnectorServerWhenStopRegionServer:123 » >> IO >>>> Shut... >>>> [ERROR] Run 2: TestJMXConnectorServer.tearDown:73 NullPointer >>>> [INFO] >>>> [WARNING] Flakes: >>>> [WARNING] >>>> >> org.apache.hadoop.hbase.master.TestRestartCluster.testRetainAssignmentOnRestart(org.apache.hadoop.hbase.master.TestRestartCluster) >>>> [ERROR] Run 1: TestRestartCluster.testRetainAssignmentOnRestart:170 » >>>> Runtime Failed construc... >>>> [INFO] Run 2: PASS >>>> [INFO] >>>> [WARNING] >>>> >> org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster.testAsyncSnapshotWillNotBlockSnapshotHFileCleaner(org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster) >>>> [ERROR] Run 1: >>>> >> TestSnapshotFromMaster.testAsyncSnapshotWillNotBlockSnapshotHFileCleaner:445 >>>> [INFO] Run 2: PASS >>>> [INFO] >>>> [WARNING] >>>> >> org.apache.hadoop.hbase.replication.TestReplicationTrackerZKImpl.testGetListOfRegionServers(org.apache.hadoop.hbase.replication.TestReplicationTrackerZKImpl) >>>> [ERROR] Run 1: >>>> TestReplicationTrackerZKImpl.testGetListOfRegionServers:130 expected:<1> >>>> but was:<2> >>>> [INFO] Run 2: PASS >>>> [INFO] >>>> [INFO] >>>> [ERROR] Tests run: 4068, Failures: 0, Errors: 3, Skipped: 48, Flakes: 3 >>>> >>>> >>>> On Sun, Aug 18, 2019 at 12:52 AM Artem Ervits <artemerv...@gmail.com> >>>> wrote: >>>> >>>>> I'm not replacing any jars, deploying as is. I did check, branch-2.1 is >>>>> based on Hadoop 2.7.7. that was my next step, will redeploy >>>>> pseudodistributed cluster with 2.7 instead of 2.8, or recompile HBase >>>>> with >>>>> 2.8.5. probably latter. >>>>> >>>>> Thanks Duo. >>>>> >>>>> On Sat, Aug 17, 2019, 8:51 AM 张铎(Duo Zhang) <palomino...@gmail.com> >>>>> wrote: >>>>> >>>>>> So how do you start the hbase cluster? Replace the hadoop jars with >>>>> 2.8.5? >>>>>> Usually this will not work, you need to recompile from source and set >>>>> the >>>>>> hadoop version to 2.8.5. And also, you do not need to change the >> client >>>>>> hadoop library only if you want to use a HDFS cluster with higher >>>>> version. >>>>>> The 2.7.x DFSClient can communicate with HDFS with higher version. >>>>>> >>>>>> Maybe we should add this to our ref guide... >>>>>> >>>>>> Artem Ervits <artemerv...@gmail.com> 于2019年8月17日周六 下午8:23写道： >>>>>> >>>>>>> +0 (non-binding) >>>>>>> >>>>>>> Deployed on 2.8.5 pseudodistributed: NOK >>>>>>> Ran into issue similar to [1] >>>>>>> >>>>>>> Will retry with 2.7 on Monday unless vote changes by then. >>>>>>> >>>>>>> hbase-vote script: OK, profile for tests used runSmallTests >>>>>>> >>>>>>> [1] >>>>>>> >>>>>>> >>>>>> >>>>> >> https://stackoverflow.com/questions/53106952/starting-hbase-java-lang-classnotfoundexception-org-apache-htrace-samplerbuild >>>>>>> >>>>>>> On Fri, Aug 16, 2019, 11:10 PM 张铎(Duo Zhang) < >> palomino...@gmail.com> >>>>>>> wrote: >>>>>>> >>>>>>>> Reminder, we still need at least one more vote. >>>>>>>> >>>>>>>> Peter Somogyi <psomo...@apache.org>于2019年8月15日 周四23:09写道： >>>>>>>> >>>>>>>>> +1 >>>>>>>>> >>>>>>>>> * Signature, checksum: ok >>>>>>>>> * Rat check: ok >>>>>>>>> * Unit tests: ok >>>>>>>>> * Compatibility report: ok >>>>>>>>> * Release notes, changes: ok >>>>>>>>> * LTT 1M rows: ok >>>>>>>>> * Basic shell commands in standalone mode: ok >>>>>>>>> >>>>>>>>> On Wed, Aug 14, 2019 at 5:15 PM Duo Zhang <zhang...@apache.org >>> >>>>>> wrote: >>>>>>>>> >>>>>>>>>> The first release candidate for HBase 2.1.6 is available for >>>>>>> download: >>>>>>>>>> >>>>>>>>>> https://dist.apache.org/repos/dist/dev/hbase/2.1.6RC0 >>>>>>>>>> >>>>>>>>>> Maven artifacts are also available in a staging repository >> at: >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>> >>>>> >> https://repository.apache.org/content/repositories/orgapachehbase-1329/ >>>>>>>>>> >>>>>>>>>> Artifacts are signed with my key (9AD2AE49) published in our >>>>> KEYS >>>>>>> file >>>>>>>> at >>>>>>>>>> >>>>>>>>>> http://www.apache.org/dist/hbase/KEYS >>>>>>>>>> >>>>>>>>>> The tag to be voted on is 2.1.6RC0: >>>>>>>>>> >>>>>>>>>> https://github.com/apache/hbase/tree/2.1.6RC0 >>>>>>>>>> >>>>>>>>>> HBase 2.1.6 is the seventh maintenance release in the HBase >> 2.1 >>>>>> line, >>>>>>>>>> continuing on the theme of bringing a stable, reliable >>>>> database to >>>>>>> the >>>>>>>>>> Hadoop and NoSQL communities. It fixes several CVEs related >> to >>>>>>> jackson >>>>>>>> by >>>>>>>>>> upgrading jackson-databind dependency to 2.9.9.2, all hbase >>>>> users >>>>>> are >>>>>>>>>> highly recommended to upgrade, especially the one who uses >>>>>>> hbase-rest. >>>>>>>>>> >>>>>>>>>> 2.1.6 includes ~127 bug and improvement fixes done since the >>>>> 2.1.5. >>>>>>>> There >>>>>>>>>> are several critical fixes around WAL, which may cause WAL >>>>>> corruption >>>>>>>> or >>>>>>>>>> hang the region server. Please see HBASE-22539, HBASE-22681, >>>>>>>> HBASE-22684 >>>>>>>>>> for more details. >>>>>>>>>> >>>>>>>>>> The detailed source and binary compatibility report vs 2.1.5 >>>>> has >>>>>> been >>>>>>>>>> published for your review, at: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >> https://dist.apache.org/repos/dist/dev/hbase/2.1.6RC0/compatibility_report_2.1.5vs2.1.6RC0.html >>>>>>>>>> >>>>>>>>>> The report shows no incompatibilities. >>>>>>>>>> >>>>>>>>>> The full list of fixes included in this release is available >>>>> in the >>>>>>>>>> CHANGES.md that ships as part of the release also available >>>>> here: >>>>>>>>>> >>>>>>>>>> >>>>> https://dist.apache.org/repos/dist/dev/hbase/2.1.6RC0/CHANGES.md >>>>>>>>>> >>>>>>>>>> The RELEASENOTES.md are here: >>>>>>>>>> >>>>>>>>>> >>>>>>>> >>>>> https://dist.apache.org/repos/dist/dev/hbase/2.1.6RC0/RELEASENOTES.md >>>>>>>>>> >>>>>>>>>> Please try out this candidate and vote +1/-1 on whether we >>>>> should >>>>>>>> release >>>>>>>>>> these artifacts as HBase 2.1.6. >>>>>>>>>> >>>>>>>>>> The VOTE will remain open for at least 72 hours. >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>
