Sorry, I should have been clear, I was talking about bug fixes and non-feature commits only. But I think I got the overall idea, it doesn't make sense to create maintenance release cut for minor release and "feature freeze" should definitely be followed. Thanks Duo.
On 2020/07/02 14:19:34, 张铎(Duo Zhang) <[email protected]> wrote: > Once we cut a release branch, it usually means the branch is in a 'feature > freeze' state, which means we should not add any new features to the branch > any more. > > We do have some commits only go to branch-2, without back porting to > branch-2.3. But I think the problem here is that there are still lots of > bug fixes and small improvements. > > Viraj Jasani <[email protected]> 于2020年7月2日周四 下午9:52写道： > > > > the fix version is 2.3.1, but actually it is before the 2.3.0RC1 > > tag so I think it should be set to 2.3.0? > > > > > which was committed to the branch but the > > issue not yet resolved. > > > > Reg this same discussion, is it a good practice to cut branch-2.3.0 > > from branch-2.3 in such busy dev cycles where there are more commits > > landing on all active branch-2.x daily so that only relevant commits > > are backported to branch-2.3.0 from branch-2.3 > > that RM feels comfortable releasing with 2.3.0? Or we don't > > create branch for maintenance release? (some standard practice?) > > > > > > On 2020/07/02 06:23:25, Viraj Jasani <[email protected]> wrote: > > > > Do you happen to have the xml file from the failed test? > > > Would be good to file it as a flakey test. > > > > > > Yes, sure, let me take a detailed look and file one. > > > > > > > > > On 2020/07/01 19:21:33, Nick Dimiduk <[email protected]> wrote: > > > > Last night's ITBLL run of rc1 had the master saturated with stuck > > > > procedures, HBASE-24526. It looks like a bug in ServerCrashProcedure. > > I'm > > > > still investigating. If anyone wants to attempt a repro, I've been > > using > > > > ServerKillingMonkey. > > > > > > > > On Wed, Jul 1, 2020 at 12:03 PM Nick Dimiduk <[email protected]> > > wrote: > > > > > > > > > On Wed, Jul 1, 2020 at 2:42 AM Viraj Jasani <[email protected]> > > wrote: > > > > > > > > > >> * Unit tests pass (1.8.0_251): failed > > > > >> - mvn package -P runAllTests > > > > >> > > > > >> > > > > >> [ERROR] Tests run: 16, Failures: 1, Errors: 0, Skipped: 0, Time > > elapsed: > > > > >> 483.486 s <<< FAILURE! - in > > > > >> org.apache.hadoop.hbase.replication.TestReplicationSmallTests > > > > >> [ERROR] > > > > >> > > org.apache.hadoop.hbase.replication.TestReplicationSmallTests.testLoading[1: > > > > >> serialPeer=false] Time elapsed: 258.127 s <<< FAILURE! > > > > >> java.lang.AssertionError: Waited too much time for normal batch > > > > >> replication, 0 instead of 1000; waited=257048ms > > > > >> at > > > > >> > > org.apache.hadoop.hbase.replication.TestReplicationSmallTests.testLoading(TestReplicationSmallTests.java:339) > > > > >> > > > > >> Iterated over TestReplicationSmallTests (it is LargeTests) 10 times, > > > > >> no issues reported in any run. > > > > >> > > > > > > > > > > Thanks Viraj. Do you happen to have the xml file from the failed > > test? > > > > > Would be good to file it as a flakey test. > > > > > > > > > > On 2020/06/29 19:00:26, Nick Dimiduk <[email protected]> wrote: > > > > >> > Please vote on this Apache hbase release candidate, > > > > >> > hbase-2.3.0RC1 > > > > >> > > > > > >> > The VOTE will remain open for at least 72 hours. > > > > >> > > > > > >> > [ ] +1 Release this package as Apache hbase 2.3.0 > > > > >> > [ ] -1 Do not release this package because ... > > > > >> > > > > > >> > The tag to be voted on is 2.3.0RC1: > > > > >> > > > > > >> > https://github.com/apache/hbase/tree/2.3.0RC1 > > > > >> > > > > > >> > The release files, including signatures, digests, as well as > > CHANGES.md > > > > >> > and RELEASENOTES.md included in this RC can be found at: > > > > >> > > > > > >> > https://dist.apache.org/repos/dist/dev/hbase/2.3.0RC1/ > > > > >> > > > > > >> > Maven artifacts are available in a staging repository at: > > > > >> > > > > > >> > > > > > >> > > https://repository.apache.org/content/repositories/orgapachehbase-1394/ > > > > >> > > > > > >> > Artifacts were signed with the [email protected] key which can > > be > > > > >> found > > > > >> > in: > > > > >> > > > > > >> > https://dist.apache.org/repos/dist/release/hbase/KEYS > > > > >> > > > > > >> > To learn more about Apache hbase, please see > > > > >> > > > > > >> > http://hbase.apache.org/ > > > > >> > > > > > >> > Thanks, > > > > >> > Your HBase Release Manager > > > > >> > > > > > >> > > > > > > > > > > > > > > >
