We are already flattening and the proposed change adds release artifacts for hadoop3 using a new “hadoop3” classifier — at least, that is the plan, let’s see if it works — and so the changes are additive. The default build, which downstreamers consume as of 2.5.0 and all previous releases, remains unchanged with respect to its dependency set. I think this means the changes are additive and orthogonal. That said I’d be fine with waiting until 2.6.0 to introduce the hadoop3 variant… in which case I would begin work on 2.6.0RC0 for anticipated release this calendar year. YDYT?
> On Sep 27, 2022, at 7:15 AM, 张铎 <palomino...@gmail.com> wrote: > > But I think flatten the pom profiles itself is also useful? It does > not make sense(and also does not work...) to activate a profile which > pulls in jars that are different from the ones we depend at the time > when building the hbase artifacts... > > Nick Dimiduk <ndimi...@apache.org> 于2022年9月27日周二 19:48写道： > >> >> Yes -- that's why I brought it up in this discussion. I think that we >> should either finish the effort before 2.5.1 or revert it from >> branch-2.5 until we have a more complete implementation in place. >> >>> On Tue, Sep 27, 2022 at 12:15 PM 张铎(Duo Zhang) <palomino...@gmail.com> >>> wrote: >>> >>> We already include HBASE-27340 in branch-2.5... So in the 2.5.1 >>> release we will flatten the pom file, if we do not revert this >>> commit... >>> >>> Nick Dimiduk <ndimi...@apache.org> 于2022年9月27日周二 16:46写道： >>>> >>>> I am also concerned about the feature that squashes out the profiles from >>>> our poms. To me, specifying the maven profile at build time is a part of >>>> the API contract that we should not break in a patch release. I’d like to >>>> see that feature integrated into the do-release tooling such that two sets >>>> of squished artifacts/maven repos are produced. And of course, updating the >>>> docs to explain how these are consumed. >>>> >>>> Maybe we need a minor release line where we ship both the old style and the >>>> new style artifacts? We could do that with 2.5… >>>> >>>> Thanks, >>>> Nick >>>> >>>> On Tue, Sep 27, 2022 at 03:40 张铎(Duo Zhang) <palomino...@gmail.com> wrote: >>>> >>>>> Thanks Andrew for taking care of this. >>>>> >>>>> For me there is an issue HBASE-27359, where we can publish different >>>>> maven artifacts for hadoop2 and hadoop3, it can solve the problem >>>>> brought up by the phoenix guys. Do you think we should include this in >>>>> branch-2.5 and start from 2.5.1 or maybe 2.5.2 if it is too late for >>>>> 2.5.1, to publish different maven artifacts for hadoop2 and hadoop3, >>>>> or we still keep 2.5.x as is, and include this in the up coming 2.6.x >>>>> release line? >>>>> >>>>> Thanks. >>>>> >>>>> Andrew Purtell <apurt...@apache.org> 于2022年9月27日周二 06:52写道： >>>>> >>>>>> >>>>>> It has been about a month since 2.5.0 and there are ~42 issues >>>>>> < >>>>> https://issues.apache.org/jira/issues/?jql=project%3Dhbase%20and%20(%20fixVersion%3D2.5.1%20or%20affectedVersion%20%3D%202.5.1%20) >>>>>> >>>>>> related to 2.5.1. This week I will be grooming the issue tracker for a RC >>>>>> next week.If you have any pending work for branch-2.5 that you would like >>>>>> to get in, please set the fix version accordingly. >>>>>> >>>>>> -- >>>>>> Best regards, >>>>>> Andrew >>>>>
