After the recent update of the design and implementation, change my vote to +1. Detailed can be found in the discussion on the PR.
https://github.com/apache/hbase/pull/4556 So we have gotten 3 +1s for merging back the feature branch to master. Thanks. 张铎(Duo Zhang) <[email protected]> 于2022年6月22日周三 12:10写道： > > Left some comments on the PR. > > PTAL. > > Thanks. > > 张铎(Duo Zhang) <[email protected]> 于2022年6月22日周三 10:08写道： >> >> Skimmed the design doc, I think it is a very useful feature for detecting >> and debugging replication inconsistencies. Good job. >> >> And since the feature is default off, I'm optimistic that we can merge it >> first and then keep polishing it in the future, as it will not affect the >> normal write and replication flow. >> >> Let me take a look at the PR and report back here. The first suggestion is >> that, please use lower case table names, as all our system tables are in >> lower case :) >> >> Thanks for the great work. >> >> Andrew Purtell <[email protected]> 于2022年6月22日周三 06:29写道： >>> >>> +1 >>> >>> > On Jun 21, 2022, at 10:07 AM, Rushabh Shah >>> > <[email protected]> wrote: >>> > >>> > Hi everyone, >>> > >>> > I'm writing this request to propose a merge of HBASE-26913[1] "Replication >>> > Observability Framework" to master and branch-2. >>> > The goal is to persist replication related metadata to newly created hbase >>> > tables to reduce MTTD (Mean Time To Detect) and >>> > MTTR (Mean Time To Repair) replication inconsistencies between Primary and >>> > DR clusters. >>> > The design doc is here[2]. >>> > >>> > We have created 2 new hbase tables, REPLICATION.WALEVENTTRACKER and >>> > REPLICATION.SINK_TRACKER. The first table >>> > will store all the WAL events (ACTIVE, ROLLING, ROLLED) along with >>> > metadata >>> > (wal name, wal length, region server name, timestamp) >>> > from all region servers. We have introduced a new chore called >>> > ReplicationMarkerChore which will create special marker/sentinel rows >>> > periodically (which is configurable) and inject them directly to WAL. This >>> > marker rows will be handled specially and replicated to >>> > sink cluster and will be persisted to REPLICATION.SINK_TRACKER table. >>> > >>> > Highlights >>> > * The entire feature is configurable. Defaults to false. >>> > * A new section is added to the HBase book which covers the feature and >>> > how >>> > to use it. >>> > >>> > The vote will open for at least 72 hours. >>> > Please vote: >>> > [+1] Merge the changes from HBASE-26913 to master/branch-2 >>> > [+/-0] Neutral >>> > [-1] Disagree (please include actionable feedback) >>> > >>> > 1. https://issues.apache.org/jira/browse/HBASE-26913 >>> > 2. >>> > https://docs.google.com/document/d/14oZ5ssY28hvJaQD_Jg9kWX7LfUKUyyU2PCA93PPzVko/edit#heading=h.9oum2kn0zj5r >>> > >>> > >>> > Thanks, >>> > Rushabh
