I may ping you in a different email but I tried to run those failed and flaky tests individually, they passed and I didn't find them in the nightly.
If we need to open a JIRA for fixing TestTableShell, I may need your help to collect the stacktrace? # RC build directory $ pwd /Users/taklwu/hbase-vote/2.5.3RC0/output/hbase # in hbase-shell $ mvn test -Dtest=TestTableShell --settings ~/hbase-vote/2.5.3RC0/output/hbase-repo-QlbPO/tmp-settings.xml # in hbase-server $ mvn test -Dtest=TestSlowLogAccessor,TestAsyncTableRegionReplicasGet --settings ~/hbase-vote/2.5.3RC0/output/hbase-repo-QlbPO/tmp-settings.xml [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 74.324 s - in org.apache.hadoop.hbase.client.TestTableShell [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.152 s - in org.apache.hadoop.hbase.namequeues.TestSlowLogAccessor [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 80.704 s - in org.apache.hadoop.hbase.client.TestAsyncTableRegionReplicasGet -Stephen On Wed, Jan 25, 2023 at 12:35 PM Andrew Purtell <apurt...@apache.org> wrote: > +1 (binding) > > * Signature: ok > * Checksum : ok > * Rat check (1.8.0_332): ok > - mvn clean apache-rat:check > * Built from source (1.8.0_332): ok > - mvn clean install -DskipTests > * Unit tests pass (1.8.0_332): failed, some flakes, TestTableShell > consistently fails > - mvn package -P runAllTests -Dsurefire.rerunFailingTestsCount=3 > > Checked the API compatibility report. Changes are allowable by our > guidelines. > > Flaky tests: > TestSlowLogAccessor.testHigherSlowLogs:209 Waiting timed out after > [7,000] msec > > > TestAsyncTableRegionReplicasGet>AbstractTestAsyncTableRegionReplicasRead.testNoReplicaRead:183 > expected:<0> but was:<2> > TestUnknownServers.testListUnknownServers:58 expected:<1> but was:<2> > > Failing tests: > org.apache.hadoop.hbase.client.TestTableShell.testRunShellTests > Run 1: TestTableShell>AbstractTestShell.testRunShellTests:94 » > EvalFailed (RuntimeError) Shell unit tests failed. Check output file for > details. > Run 2: TestTableShell>AbstractTestShell.testRunShellTests:94 » > EvalFailed (RuntimeError) > test_Hbase::Table_constructor_should_not_fail_for_existent_tables is > already defined in Hbase::TableConstructorTest > Run 3: TestTableShell>AbstractTestShell.testRunShellTests:94 » > EvalFailed (RuntimeError) > test_Hbase::Table_constructor_should_not_fail_for_existent_tables is > already defined in Hbase::TableConstructorTest > Run 4: TestTableShell>AbstractTestShell.testRunShellTests:94 » > EvalFailed (RuntimeError) > test_Hbase::Table_constructor_should_not_fail_for_existent_tables is > already defined in Hbase::TableConstructorTest > > > On Wed, Jan 25, 2023 at 9:50 AM Tak Lon (Stephen) Wu <tak...@apache.org> > wrote: > > > Please vote on this Apache hbase release candidate, > > hbase-2.5.3RC0 > > > > The VOTE will remain open for at least 72 hours. > > > > [ ] +1 Release this package as Apache hbase 2.5.3 > > [ ] -1 Do not release this package because ... > > > > The tag to be voted on is 2.5.3RC0: > > > > https://github.com/apache/hbase/tree/2.5.3RC0 > > > > This tag currently points to git reference > > > > 05108d40c9e049ae778009044a032d9699ec044a > > > > The release files, including signatures, digests, as well as CHANGES.md > > and RELEASENOTES.md included in this RC can be found at: > > > > https://dist.apache.org/repos/dist/dev/hbase/2.5.3RC0/ > > > > Maven artifacts are available in a staging repository at: > > > > > https://repository.apache.org/content/repositories/orgapachehbase-1506/ > > > > Maven artifacts for hadoop3 are available in a staging repository at: > > > > > https://repository.apache.org/content/repositories/orgapachehbase-1507/ > > > > Artifacts were signed with the 0xE935AD54 key which can be found in: > > > > https://downloads.apache.org/hbase/KEYS > > > > To learn more about Apache hbase, please see > > > > http://hbase.apache.org/ > > > > Thanks, > > Your HBase Release Manager > > > > > -- > Best regards, > Andrew > > Unrest, ignorance distilled, nihilistic imbeciles - > It's what we’ve earned > Welcome, apocalypse, what’s taken you so long? > Bring us the fitting end that we’ve been counting on > - A23, Welcome, Apocalypse >