And do we want to apply the same trick to MasterObserver and RegionServerObserver?
For RegionObserver, we'd better do this because there are already methods in it that use the ObserverContext<? extends RegionCoprocessorEnvironment> declaration, which were added in HBASE-10378. For other coprocessor observers, we do not have such methods yet. Nick Dimiduk <ndimi...@apache.org> 于2024年9月19日周四 22:03写道： > > We do it here or we wait for 4.0. I'm inclined toward doing it here > because (i think) we expect coprocessor implementations to necessarily > recompile anyway. Though I admit I've not thought through what features are > enabled by this new generic signature. > > On Thu, Sep 19, 2024 at 3:57 PM 张铎(Duo Zhang) <palomino...@gmail.com> wrote: > > > Filed HBASE-28862. > > > > It will break old coprocessor implementations even if they do not use > > any deprecated method. But since it does not change any abilities, I > > think it is OK to include this in a major release as we have already > > done bunch of breaking changes, like changing the protobuf from > > unshaded one to shaded and relocated one... > > > > Thanks. > > > > 张铎(Duo Zhang) <palomino...@gmail.com> 于2024年9月19日周四 17:36写道： > > > > > > Thanks for pointing this TODO out. > > > > > > Let me file an issue abort this. For me I think we should do this in > > 3.0.0. > > > > > > Nick Dimiduk <ndimi...@apache.org> 于2024年9月19日周四 16:46写道： > > > > > > > > Should we take the opportunity to upgrade the generic definitions in > > our > > > > coprocessor signatures as well? > > > > > > > > > > https://github.com/apache/hbase/blob/edbb145a3f0c6847f444fefdadea5b82d02b0bdb/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java#L101 > > > > > > > > On Tue, Sep 17, 2024 at 4:41 PM Duo Zhang <zhang...@apache.org> wrote: > > > > > > > > > I've done several rounds of API cleanup in HBASE-24888 and now for me > > > > > I think it is enough for making the new major release. > > > > > > > > > > I've filed HBASE-28844 for aligning the commit history and jira > > > > > issues, it will be a huge project for a major release and may take > > > > > several weeks. > > > > > > > > > > After that, I think we are good to go. And I will also try to find > > > > > some resources to run several rounds of ITBLL and also some upgrading > > > > > tests. Finally, after everything is OK, I will release 3.0.0-beta-2, > > > > > and then cut branch-3.0 from the 3.0.0-beta-2 tag and make the 3.0.0 > > > > > release soon. > > > > > > > > > > Hope I can get all these things done within the year 2024. > > > > > > > > > > Thanks. > > > > > > >
