[ https://issues.apache.org/jira/browse/HTTPCLIENT-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730791#action_12730791 ]
Oleg Kalnichevski commented on HTTPCLIENT-523: ---------------------------------------------- Matthew, Things are shaping up pretty good. However, ideally I would like to have a few fairly minor points addressed before I go ahead and commit the code to the official repository. (1) What is the reason for using mutable static variables (STRIPPORT, SPNEGOCREATE, SpengoGenerator)? Could you please consider changing those variables into regular instance variables? (2) Ideally I would prefer to have the SPNEGO documentation converted to the docbkx format and if possible integrated into the HttpClient tutorial [1] Oleg [1] http://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk/src/docbkx/ > SPNEGO authentication scheme > ---------------------------- > > Key: HTTPCLIENT-523 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-523 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpAuth > Affects Versions: Snapshot > Environment: Operating System: All > Platform: All > Reporter: Mikael Wikström > Priority: Minor > Fix For: 4.1.0 > > Attachments: bcsLogin.conf, > CustomAuthenticationNegotiateExample.java, > CustomAuthenticationNegotiateExample.java, httpclient4kerb20090710.zip, > KerberosHttpClient.zip, NegotiateScheme.java, NegotiateScheme.java, run.sh, > submitclient.tar.gz > > > Consider integrating the SPNEGO auth scheme from Commons HttpClient contrib > package into HttpClient 4.0 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org