[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754695#action_12754695
 ] 

Oleg Kalnichevski commented on HTTPCLIENT-523:
----------------------------------------------

Matthew,

I committed your patch with some minor changes to the SVN head. Please review / 
double-check

http://svn.apache.org/viewvc?view=rev&revision=814311

A few notes:

(1) I copied content of krb5.conf and login.conf files to the 
ClientKerberosAuthentication sample to make it self-contained. Ideally the 
example should have a little more documentation in the javadocs. Please 
consider putting some more work into it.

(2) We cannot have dependencies on external libraries such as BouncyCastle JCE 
implementation in examples. Ideally sample files should be functional with the 
standard set of dependencies. Worst case I would rather have that example 
require Java 1.6 to run as long as it complies with Java 1.5 and the runtime 
dependency on 1.6 is clearly documented in the javadocs

(3) I moved BouncySpnegoTokenGenerator class to the contrib (unsupported) area 
for the reason given above:
http://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk/contrib/org/apache/http/contrib/auth/BouncySpnegoTokenGenerator.java
 

Many thanks for this contribution. I am sure quite a few people are going to be 
quite happy about it!

I'll close this issue as resolved as soon as the BouncyCastle dependency issue 
is sorted out and the tutorial content is brushed up a little.

Oleg

> SPNEGO authentication scheme
> ----------------------------
>
>                 Key: HTTPCLIENT-523
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-523
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpAuth
>    Affects Versions: Snapshot
>         Environment: Operating System: All
> Platform: All
>            Reporter: Mikael Wikström
>            Priority: Minor
>             Fix For: 4.1.0
>
>         Attachments: bcsLogin.conf, 
> CustomAuthenticationNegotiateExample.java, 
> CustomAuthenticationNegotiateExample.java, httpclient4kerb20090710.zip, 
> KerberosHttpClient.zip, NegotiateScheme.java, NegotiateScheme.java, run.sh, 
> SPNEGO.patch, SPNEGO_cropped.png, submitclient.tar.gz
>
>
> Consider integrating the SPNEGO auth scheme from Commons HttpClient contrib 
> package into HttpClient 4.0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to