[
https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747704#action_12747704
]
Sebb commented on HTTPCLIENT-866:
---------------------------------
Looks good.
However, I think the RetentionPolicy should probably be CLASS (i.e. the
default), not SOURCE.
I've tried compiling with this and Sun Java does not complain.
Using CLASS retention would mean that the annotation should be available to
tools that process class files.
> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
> Key: HTTPCLIENT-866
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Affects Versions: 4.0 Final
> Environment: javac 1.5.0_19
> Reporter: David Nault
> Priority: Critical
> Fix For: 4.0.1, 4.1.0
>
> Attachments: HTTPCLIENT-866.patch
>
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar
> must be in the classpath or else you get a compiler error:
> [javac] /path/to/src/SomeFile.java:129: cannot access
> net.jcip.annotations.GuardedBy
> [javac] file net/jcip/annotations/GuardedBy.class not found
> [javac] DefaultHttpClient httpclient = new DefaultHttpClient();
> [javac] ^
> With Java 6, you get a bunch of warnings instead.
> [javac]
> org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class):
> warning: Cannot find annotation method 'value()' in type
> 'net.jcip.annotations.GuardedBy': class file for
> net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and
> jcip-annotations.jar is not included in the
> "httpcomponents-client-4.0-bin-with-dependencies" package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
