[
https://issues.apache.org/jira/browse/HTTPCORE-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801147#action_12801147
]
Oleg Kalnichevski commented on HTTPCORE-212:
--------------------------------------------
> CharArrayBuffer buffer = new CharArrayBuffer(this.hostname.length() + 6);
committed.
As far as the integer parsing is concerned, I can't help thinking the benefit
of optimization does not outweigh the cost of extra code complexity. At the
very least for the consistency sake we should also make similar change to the
BasicLineFormatter and get rid of Integer.toString().
In my opinion it is just not worth it. However, If you are willing to invest
more effort into this issue and eliminate Integer#parseInt() and
Integer#toString() calls consistently across the entire org.apache.http.message
package, I will be happy to review and commit the patch.
Nonetheless I suggest we close this issue as resolved and move on. Our time and
efforts can be better spent elsewhere.
Oleg
> Minor performance improvements
> ------------------------------
>
> Key: HTTPCORE-212
> URL: https://issues.apache.org/jira/browse/HTTPCORE-212
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore
> Reporter: Tony Poppleton
> Priority: Minor
> Fix For: 4.1-beta1
>
> Attachments: BasicLineParser.java.patch, BasicLineParser.java.patch2,
> BasicLineParser.java.patch3, HttpHost.java.patch, HttpHost.java.patch2,
> HttpHost.java.patch3, HttpHostBenchmark.java
>
>
> JProfiler highlighted a few minor bottlenecks in HttpCore, and two patches
> are attached.
> Neither of these two patches has been benchmarked in a proper fashion, I just
> observed that they dropped of the JProfiler radar (which isn't a thorough way
> of doing this and may be wrong!). Could someone with a benchmarking suite
> already setup please test these patches for performance to confirm they are
> indeed faster and also if possible ascertain how much faster.
> The first patch is to remove the unnecessary creation of a CharArrayBuffer in
> HttpHost.toHostString. In cases without a port, there is no object creation
> at all now, and in cases with a port then Java string concatenation is used
> (and optimized away in recent JVMs).
> The second patch is more involved and affects BasicLineParser. Given that
> all of my responses are being processed with this class, I decided I should
> look at optimizing it. The main culprit is the string creation in
> CharArrayBuffer.substringTrimmed which is only required to be able to call
> the Java Integer.parseInt method. I normally prefer using Java classes where
> possible, however this patch implements a custom parseInt method which also
> removes the need for the indexOf operation (so the CharArrayBuffer/String is
> now only scanned once rather than twice).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
