[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835739#action_12835739
 ] 

Steinar H. Gunderson commented on HTTPCLIENT-898:
-------------------------------------------------

Two comments:

- Please don't use Collections.shuffle() on the address list. The list comes 
from the resolver in a given order for good reasons (see RFC 3484), and 
randomizing it will do Very Bad Things in some situations.
- The address list can potentially be very long (20+ addresses). Trying to 
divide the timeout evenly between these addresses might not be the best thing 
to do. Most other libraries simply specify that timeout is done once per host 
tried, which would probably not be unreasonable here either.

> Improve multihome support
> -------------------------
>
>                 Key: HTTPCLIENT-898
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-898
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpConn
>    Affects Versions: 4.0 Final, 4.0.1, 4.1 Alpha1
>            Reporter: Oleg Kalnichevski
>             Fix For: 4.1 Alpha2
>
>
> MultihomePlainSocketFactory is basically broken and should be deprecated. 
> Multihome logic needs to be moved to the DefaultClientConnectionOperator

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to