[
https://issues.apache.org/jira/browse/HTTPCLIENT-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844089#action_12844089
]
Oleg Kalnichevski commented on HTTPCLIENT-898:
----------------------------------------------
I did not realize you were with Google. My bad. I should have looked at your
profile.
(1) Do you happen to know if Andoid project has any plans of syncing their code
line to the official HttpClient 4.0.x branch at some point of time?
(2) As far your patch is concerned it does solve the problem. However I would
prefer a more radical but somewhat cleaner approach. I am thinking about
deprecating the actual SocketFactory and LayeredSocketFactory interfaces and
all implementing classes and replacing them with similar interfaces that are
multihome capable
---
public interface SocketFactory {
Socket createSocket() throws IOException;
Socket connectSocket(
Socket sock,
String hostname,
InetAddress removeAddress,
int port,
InetAddress localAddress,
int localPort,
HttpParams params
) throws IOException, UnknownHostException, ConnectTimeoutException;
boolean isSecure(Socket sock) throws IllegalArgumentException;
}
---
Alternatively we could introduce a optional interface for multihome support,
which would be slightly uglier but would allow us to continue using all old
interfaces and classes.
What would be your preference?
Oleg
> Improve multihome support
> -------------------------
>
> Key: HTTPCLIENT-898
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-898
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpConn
> Affects Versions: 4.0 Final, 4.0.1, 4.1 Alpha1
> Reporter: Oleg Kalnichevski
> Fix For: 4.1 Alpha2
>
>
> MultihomePlainSocketFactory is basically broken and should be deprecated.
> Multihome logic needs to be moved to the DefaultClientConnectionOperator
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
