[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971022#action_12971022
 ] 

Sebb commented on HTTPCLIENT-911:
---------------------------------

OK, I'll remove it.

It looks as though getAuthority() can be used even if the host part contains an 
underscore.

So one approach might be to use getHost() as before; if that returns null, then 
use getAuthority(), and strip off up to the "@" if present.

At least if we use getHost() when we can, there will be fewer chances of bugs...


> Support underscore in domain name, or provide better exception
> --------------------------------------------------------------
>
>                 Key: HTTPCLIENT-911
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-911
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.0.1
>            Reporter: Ziv Horesh
>            Priority: Minor
>             Fix For: 4.1 Alpha2
>
>         Attachments: HTTPCLIENT-911.patch
>
>
> When calling on HttpClient.execute with a url that contain underscore ('_'), 
> you get NullPointerException.
> Tracing it down show that java.net.Uri complains that it is illegal name. 
> Which is true according to the RFC.
> But it seems that most browser allow it, and some companies support it.
> I think HttpClient should either support underscores, or atleast provide a 
> better exception.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to