[
https://issues.apache.org/jira/browse/HTTPCLIENT-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096085#comment-13096085
]
Michael Pujos commented on HTTPCLIENT-1122:
-------------------------------------------
Noted, although this will be impossible to reproduce. Stack trace seems legit
though. Proguard optimizations were disabled.
Recent versions of HttpComponents has been very little tested on Android as
99.999% of Android developers use the httpclient/httpcore of the platform from
2008
that has been hacked by Google.
There might be some specific bugs on Android, especially due to bad
connectivity that can be lost at any time, more often that any other platform.
I've had very few issues with 4.1.1 besides a few more HTTPCORE-263 crashes in
automatic user crash reports (with matching backtrace lines this time).
For this specific issue, why not add null checks for calls to conn.getRoute() ?
> NPE in RequestProxyAuthentication on Android
> --------------------------------------------
>
> Key: HTTPCLIENT-1122
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1122
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.1.1
> Environment: Android 2.3.4. Using repackaged httpcore 4.1.1 in an app
> obfuscated with Proguard.
> must be very rare as I only saw it once for > 10K users.
> Reporter: Michael Pujos
> Priority: Minor
>
> Got a NPE backtrace in RequestProxyAuthentication.process().
> HttpRoute route = conn.getRoute();
> if (route.isTunnelled()) { <= line 88, NPE here
> return;
> }
> There's no null check on the returned route although getRoute() can return
> null.
> I guess it's not supposed to happen.
> In the httpclient code, there's a few more calls to getRoute() without a null
> check on the returned route.
> java.lang.NullPointerException
> at
> com.bubblesoft.org.apache.http.client.protocol.RequestProxyAuthentication.process(SourceFile:88)
> at
> com.bubblesoft.org.apache.http.protocol.ImmutableHttpProcessor.process(SourceFile:108)
> at
> com.bubblesoft.org.apache.http.protocol.HttpRequestExecutor.preProcess(SourceFile:174)
> at
> com.bubblesoft.org.apache.http.impl.client.DefaultRequestDirector.execute(SourceFile:457)
> at
> com.bubblesoft.org.apache.http.impl.client.AbstractHttpClient.createHttpProcessor(SourceFile:821)
> execute
> at
> com.bubblesoft.org.apache.http.impl.client.AbstractHttpClient.createHttpProcessor(SourceFile:755)
> execute
> at
> com.bubblesoft.org.apache.http.impl.client.AbstractHttpClient.createHttpProcessor(SourceFile:733)
> execute
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]