[
https://issues.apache.org/jira/browse/HTTPCLIENT-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114994#comment-13114994
]
Michael Pujos commented on HTTPCLIENT-1122:
-------------------------------------------
Thanks for the fix.
Here's another stack trace that looks legit on an unchecked null route, that
might confirm there was indeed a problem:
java.lang.NullPointerException
at
com.bubblesoft.org.apache.http.client.protocol.RequestClientConnControl.process(SourceFile:86)
at
com.bubblesoft.org.apache.http.protocol.ImmutableHttpProcessor.process(SourceFile:108)
at
com.bubblesoft.org.apache.http.protocol.HttpRequestExecutor.preProcess(SourceFile:174)
at
com.bubblesoft.org.apache.http.impl.client.DefaultRequestDirector.execute(SourceFile:457)
at
com.bubblesoft.org.apache.http.impl.client.AbstractHttpClient.createHttpProcessor(SourceFile:821)
execute$1650775d
at
com.bubblesoft.org.apache.http.impl.client.AbstractHttpClient.createHttpProcessor(SourceFile:733)
execute
at com.bubblesoft.android.utils.AndroidHttpClient.execute(SourceFile:279)
at com.bubblesoft.android.utils.BitmapDownload.download(SourceFile:56)
at com.bubblesoft.android.utils.BitmapDownloadTask.doInBackground(SourceFile:33)
at com.bubblesoft.android.utils.BitmapDownloadTask.doInBackground(SourceFile:1)
at android.os.AsyncTask$2.call(AsyncTask.java:185)
> NPE in RequestProxyAuthentication on Android
> --------------------------------------------
>
> Key: HTTPCLIENT-1122
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1122
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.1.1
> Environment: Android 2.3.4. Using repackaged httpcore 4.1.1 in an app
> obfuscated with Proguard.
> must be very rare as I only saw it once for > 10K users.
> Reporter: Michael Pujos
> Priority: Minor
> Fix For: 4.2 Alpha1
>
>
> Got a NPE backtrace in RequestProxyAuthentication.process().
> HttpRoute route = conn.getRoute();
> if (route.isTunnelled()) { <= line 88, NPE here
> return;
> }
> There's no null check on the returned route although getRoute() can return
> null.
> I guess it's not supposed to happen.
> In the httpclient code, there's a few more calls to getRoute() without a null
> check on the returned route.
> java.lang.NullPointerException
> at
> com.bubblesoft.org.apache.http.client.protocol.RequestProxyAuthentication.process(SourceFile:88)
> at
> com.bubblesoft.org.apache.http.protocol.ImmutableHttpProcessor.process(SourceFile:108)
> at
> com.bubblesoft.org.apache.http.protocol.HttpRequestExecutor.preProcess(SourceFile:174)
> at
> com.bubblesoft.org.apache.http.impl.client.DefaultRequestDirector.execute(SourceFile:457)
> at
> com.bubblesoft.org.apache.http.impl.client.AbstractHttpClient.createHttpProcessor(SourceFile:821)
> execute
> at
> com.bubblesoft.org.apache.http.impl.client.AbstractHttpClient.createHttpProcessor(SourceFile:755)
> execute
> at
> com.bubblesoft.org.apache.http.impl.client.AbstractHttpClient.createHttpProcessor(SourceFile:733)
> execute
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
