[
https://issues.apache.org/jira/browse/HTTPCLIENT-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633933#comment-13633933
]
Oleg Kalnichevski commented on HTTPCLIENT-1238:
-----------------------------------------------
[~simao] The patch is exactly what I felt what was the right approach. All OSGi
specific aspects are kept inside the OSGi module without spilling any of its
specific aspects into other modules of HttpClient. Great gob!
Minor nitpicks
(1) My understanding is that HttpClient OSGi bundle is dependent on HttpCore
OSGi bundle and it is responsibility of HttpCore bundle to export core
packages. Can this confusion be due to the fact that HttpClient OSGi does not
correctly declare its dependency on HttpCore bundle?
(2) HttpClients interface sounds like a misnomer to me. This looks more like
HttpClientBuilderFactory. The name is uglier but more precise
(3) Can we put something in the name of the new classes to stress out their
purpose and make them more distinguishable? DefaultHttpRoutePlanner ->
OSGiHttpRoutePlanner, DefaultCredentialsProvider -> OSGiCredentialsProvider?
Shall I commit the patch as is or do you want to submit another patch?
Oleg
> Contribute Bundle Activator And Central Proxy Configuration
> -----------------------------------------------------------
>
> Key: HTTPCLIENT-1238
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1238
> Project: HttpComponents HttpClient
> Issue Type: Wish
> Components: HttpClient
> Affects Versions: 4.2.1
> Reporter: Dominique Jäggi
> Priority: Minor
> Fix For: 4.3 Final
>
> Attachments: HTTPCLIENT-1238-2.patch, HTTPCLIENT-1238-3.patch,
> HTTPCLIENT-1238-4.patch, HTTPCLIENT-1238-5.patch, HTTPCLIENT-1238.patch
>
>
> as discussed at [0] i'd like to contribute the bundle activator and central
> proxy configuration.
> the attached patch may need some cleanup on your side, as only assumed
> locations where to put some classes or in which pom.xml to put dependencies.
> i kindly ask you to review the patch in if possible integrate it in a future
> release.
> Adobe (and i as its employee) is available for assistance, explanations, or
> further dev work required in the context of the patch.
> [0]
> http://mail-archives.apache.org/mod_mbox/hc-dev/201209.mbox/%3cCACMijv-21S4+Jw_A=jdfhevb9cmt4kni5p3jahzfh3kvu4b...@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
