[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753065#comment-13753065
 ] 

Sebb commented on HTTPCLIENT-1394:
----------------------------------

Thanks for the new patch; easier to read without the tabs!

Regarding the @SuppressWarnings, OK understood.
However it helps to have an inline comment to document why they are needed.

For example, something like:

@SuppressWarnings("deprecation") // we need to support AuthSchemeFactory for now

No need to redo the patch; I just mention this for future reference.
                
> Native windows Negotiate/NTLM via JNA
> -------------------------------------
>
>                 Key: HTTPCLIENT-1394
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1394
>             Project: HttpComponents HttpClient
>          Issue Type: New Feature
>         Environment: Windows
>            Reporter: Ryan McKinley
>         Attachments: HTTPCLIENT-1394-jna.patch, HTTPCLIENT-1394-jna.patch
>
>
> HttpClient has made great progress in supporting NTLM and Negotiate, but the 
> setup often requires considerable configuration.  Using native calls, we can 
> authenticate the current logged in user directly via windows with no 
> configuration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to