[ 
https://issues.apache.org/jira/browse/HTTPCORE-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128556#comment-14128556
 ] 

Oleg Kalnichevski commented on HTTPCORE-390:
--------------------------------------------

Very interesting! 

Stephane, would it be a big deal for you to re-create the patch against SVN 
trunk (4.4 branch) and remove all commented out code as well? If you have a 
GitHub account a pull request in GitHub would probably be the most convenient 
way to get your changes integrated into HC.

Oleg

> Performance issue on AbstractNIOConnPool
> ----------------------------------------
>
>                 Key: HTTPCORE-390
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-390
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>          Components: HttpCore NIO
>    Affects Versions: 4.3.2
>            Reporter: Stephane Routhiau
>              Labels: concurrency, performance
>         Attachments: AbstractNIOConnPool.java, 
> DefaultConnectingIOReactor.java, RouteSpecificPool.java, 
> SessionRequestCallback.java, contention on lease and release.png, 
> patch-performance nio pool.patch
>
>
> AbstractNIOConnPool use a ReentrantLock for lease and release connection.
> We have noticed important contention when we try to use hundreds of 
> connexions to the same host, the lock is to vast.
> I managed to rework a part of the code so there is no more use of a 
> ReentrantLock, but use of ConcurrentHashMap and so on.
> The unit tests are ok and the load tests we have made on the patch version 
> are about 40 % faster under heavy load
> Please find attached patch file againt http-nio 4.3.2 and the modified 
> sources files of http-nio 4.3.2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to