[ 
https://issues.apache.org/jira/browse/HTTPCORE-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128626#comment-14128626
 ] 

Oleg Kalnichevski commented on HTTPCORE-390:
--------------------------------------------

Another thing. There should be no dependency on DefaultConnectingIOReactor in 
AbstractNIOConnPool. If this dependency has been introduced for compatibility 
with some test cases, we need to figure out why tests fail and adjust tests 
instead.

Oleg

> Performance issue on AbstractNIOConnPool
> ----------------------------------------
>
>                 Key: HTTPCORE-390
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-390
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>          Components: HttpCore NIO
>    Affects Versions: 4.3.2
>            Reporter: Stephane Routhiau
>              Labels: concurrency, performance
>             Fix For: 4.4-beta1
>
>         Attachments: AbstractNIOConnPool.java, 
> DefaultConnectingIOReactor.java, RouteSpecificPool.java, 
> SessionRequestCallback.java, contention on lease and release.png, 
> patch-performance nio pool.patch
>
>
> AbstractNIOConnPool use a ReentrantLock for lease and release connection.
> We have noticed important contention when we try to use hundreds of 
> connexions to the same host, the lock is to vast.
> I managed to rework a part of the code so there is no more use of a 
> ReentrantLock, but use of ConcurrentHashMap and so on.
> The unit tests are ok and the load tests we have made on the patch version 
> are about 40 % faster under heavy load
> Please find attached patch file againt http-nio 4.3.2 and the modified 
> sources files of http-nio 4.3.2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to