Oleg,

just have noticed that you started to rewrite the auth API, here are a few issues which need some improvement:

1. httpclient/src/main/java/org/apache/http/auth/AuthScheme.java:
   #getPrinciple That is supposed to be #getPricipal and not
   #getPrinciple.

2. Rename AuthState in AuthExchange: while this is a good thing, all
   instance variables spread through the code have not been renamed and
   are therefore inconsistent/confusing. Same applies for the getters
   and final statics in HttpClientContext.

3. Revision: 1692371 AuthScheme API changes; User credentials made
   optional for those schemes that do not require them. while this is a
   vital, I do not fully understand how this now works. Can you sum up
   your change in a few words or sentences?

Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to