GitHub user faisal-hameed opened a pull request:
https://github.com/apache/httpcore/pull/27
General code quality fix-1
This pull request is focused on resolving occurrences of Sonar rules
squid:S1854 - Dead stores should be removed.
squid:S1488 - Local Variables should not be declared and then immediately
returned or thrown.
squid:S1170 - Public constants should be declared "static final" rather
than merely "final".
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1854
https://dev.eclipse.org/sonar/rules/show/squid:S1488
https://dev.eclipse.org/sonar/rules/show/squid:S1170
Please let me know if you have any questions.
Faisal Hameed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DevFactory/httpcore
release/general-code-quality-fix-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpcore/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit 4fe664d9e5099e1a96fcfc3ce4ce286a4947dc1e
Author: Faisal Hameed <[email protected]>
Date: 2016-03-09T18:41:22Z
Fixing squid:S1854, squid:S1488, squid:S1170
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
