[
https://issues.apache.org/jira/browse/HTTPCLIENT-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931952#comment-15931952
]
Oleg Kalnichevski commented on HTTPCLIENT-1830:
-----------------------------------------------
Liam,
I am not sure I like the idea of re-throwing InterruptedException as
RuntimeException. This does not sound quite right. I also do not quite see a
reason for changing exception handling code in IdleConnectionEvictor. I also
would very much rather keep {{#shutdown}} and {{#awaitTermination}} as separate
methods.
I personally think that something quite simple like [this
patch|https://github.com/ok2c/httpclient/commit/aa7b44167dbea2cef63708ab8e501a11bc9bffbd]
should be sufficient, at least for 4.5.x and 4.6.x.
Oleg
> IdleConnectionEvictor created by HttpClientBuilder should awaitTermination on
> shutdown
> --------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1830
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1830
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient (classic)
> Affects Versions: 4.5.2
> Reporter: Liam Williams
> Fix For: 4.5.4, 5.0 Alpha2
>
>
> When calling InternalHttpClient.close via the CloseableHttpClient interface
> for a client created via HttpClientBuilder, IdleConnectionEvictor.shutdown is
> called, but IdleConnectionEvictor.awaitTermination is not.
> This is a problem, since there is no way to await termination apart from
> doing a dirty sleep.
> Hope this makes sense, let me know if it doesn't.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
