[
https://issues.apache.org/jira/browse/HTTPCLIENT-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932435#comment-15932435
]
ASF GitHub Bot commented on HTTPCLIENT-1830:
--------------------------------------------
Github user theangrydev commented on the issue:
https://github.com/apache/httpclient/pull/67
As discussed in
[HTTPCLIENT-1830](https://issues.apache.org/jira/browse/HTTPCLIENT-1830),
updated this pull request to keep await termination separate from the shutdown.
Keeping the uncaught exception logging in trunk but not in 4.5.x and 4.6.x.
> IdleConnectionEvictor created by HttpClientBuilder should awaitTermination on
> shutdown
> --------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1830
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1830
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient (classic)
> Affects Versions: 4.5.2
> Reporter: Liam Williams
> Fix For: 4.5.4, 5.0 Alpha2
>
>
> When calling InternalHttpClient.close via the CloseableHttpClient interface
> for a client created via HttpClientBuilder, IdleConnectionEvictor.shutdown is
> called, but IdleConnectionEvictor.awaitTermination is not.
> This is a problem, since there is no way to await termination apart from
> doing a dirty sleep.
> Hope this makes sense, let me know if it doesn't.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
