[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187188#comment-16187188
 ] 

ASF GitHub Bot commented on HTTPCLIENT-293:
-------------------------------------------

Github user sermojohn commented on the issue:

    https://github.com/apache/httpcomponents-client/pull/85
  
    Only the filename parameter of the Content-Disposition field is currently 
encoded, because it is defined by the specification (RFC 7578) that should 
support non US-ASCII characters. The other parameters, "name" (in 
Content-Disposition) and "charset" (in Content-Type) should only contain 
US-ASCII characters.
    
    I could modify the code that creates the "charset" parameter of 
Content-Type field, but I noticed that this field always appears without quotes 
around the value, which makes it a bit incompatible with the handling of the 
Content-Disposition parameters that always appear quoted. So, I believe I 
should avoid changing that code, as it also seems irrelevant with the current 
fix. Hope you agree.


> Provide support for non-ASCII charsets in the multipart disposition-content 
> header
> ----------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-293
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-293
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient (classic)
>    Affects Versions: 1.0 Alpha
>         Environment: Operating System: All
> Platform: All
>            Reporter: Eric Dofonsou
>            Priority: Minor
>             Fix For: 4.0 Beta 2
>
>
> Because of the the following line in getAsciiBytes 
>  data.getBytes("US-ASCII");
> The returned string is modified if has Latin Characters.
> Ex : Document non-controlé -> Document non-control?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to