[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185707#comment-16185707
 ] 

ASF GitHub Bot commented on HTTPCLIENT-293:
-------------------------------------------

Github user ok2c commented on the issue:

    https://github.com/apache/httpcomponents-client/pull/85
  
    @sermojohn Do you mind making a few relatively minor changes to your patch? 
    1. Could you please keep `MinimalField` immutable and move all construction 
logic to `FormBodyPartBuilder`?
    2. `FormBodyPartBuildeencodeForHeader` appears to be no longer needed. It 
should probably be removed.
    3. Could you please avoid different formatting of imports? You might need 
to tweak your IDE settings for that.


> Provide support for non-ASCII charsets in the multipart disposition-content 
> header
> ----------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-293
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-293
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient (classic)
>    Affects Versions: 1.0 Alpha
>         Environment: Operating System: All
> Platform: All
>            Reporter: Eric Dofonsou
>            Priority: Minor
>             Fix For: 4.0 Beta 2
>
>
> Because of the the following line in getAsciiBytes 
>  data.getBytes("US-ASCII");
> The returned string is modified if has Latin Characters.
> Ex : Document non-controlé -> Document non-control?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to