[
https://issues.apache.org/jira/browse/HTTPCORE-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538297#comment-16538297
]
ASF GitHub Bot commented on HTTPCORE-532:
-----------------------------------------
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/68#discussion_r201268240
--- Diff:
httpcore5-testing/src/main/java/org/apache/hc/core5/testing/nio/IOReactorExecutor.java
---
@@ -85,7 +85,10 @@ public void execute(final IOSession session) {
}))) {
if (status.compareAndSet(Status.READY, Status.RUNNING)) {
- ioReactorRef.get().start();
+ if(this instanceof AsyncServer){
--- End diff --
@xiaohu-zhang This is terrible. Even for test classes we should not be
doing things like that.
> IOReactor thread should be lazy started
> ---------------------------------------
>
> Key: HTTPCORE-532
> URL: https://issues.apache.org/jira/browse/HTTPCORE-532
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Reporter: silver9886
> Priority: Major
>
> SingleCoreIOReactor can be lazy started when it used. do not need to start
> all threads before
> any http request.
> resolve method is create new ioreactor thread every time there has new
> request util thread number limit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
