[ 
https://issues.apache.org/jira/browse/HTTPCORE-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538298#comment-16538298
 ] 

ASF GitHub Bot commented on HTTPCORE-532:
-----------------------------------------

Github user ok2c commented on a diff in the pull request:

    https://github.com/apache/httpcomponents-core/pull/68#discussion_r201268536
  
    --- Diff: 
httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/AsyncServer.java
 ---
    @@ -73,8 +73,12 @@ public AsyncServer(
         }
     
         @Override
    -    public void start() {
    -        ioReactor.start();
    +    public void start(final int i) {
    +        throw new RuntimeException("can not call start(i) method with 
AsyncServer class,maybe call serverStart method?");
    --- End diff --
    
    @xiaohu-zhang I cannot commit changes like that.


> IOReactor thread should be lazy started
> ---------------------------------------
>
>                 Key: HTTPCORE-532
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-532
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>            Reporter: silver9886
>            Priority: Major
>
> SingleCoreIOReactor can be lazy started when it used. do not need to start 
> all threads before
> any http request.
> resolve method is create new ioreactor thread every time there has new 
> request util thread number limit.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to