[
https://issues.apache.org/jira/browse/HTTPCLIENT-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538617#comment-16538617
]
Oleg Kalnichevski commented on HTTPCLIENT-1928:
-----------------------------------------------
I do not like the idea of catching and silently discarding exceptions. This is
worse than losing a persistent connection. If {{#completed}} throws an
exception, then something did go wrong at that point and it might be reasonable
to shut down the connection instead of risking it pollute the connection pool.
Oleg
> HttpAsyncClient callback should ignore exception throwed by compelete method
> ----------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1928
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1928
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Reporter: silver9886
> Priority: Major
>
> If exception throwed by completed method in FutureCallback argument in
> HttpAsyncClient.execute，the connection will be closed.
> but the exception throwed by customer code,should not affect the connection
> managed by the framework,the connection should be connected also.
> there can be a class called FutureCallbackIgnorecompelteExcepton class.
> public abstract class FutureCallbackIgnorecompelteExcepton <T> {
> private FutureCallback<T> t;
> void completed(T result){
> try{
> t.completed(result);
> }catch(Exception e)
> //ignore
> }
> void failed(Exception ex);
> void cancelled();
> }
> HttpAsyncClient changed as:
> HttpAsyncClient.<T> Future<T> execute(
> AsyncRequestProducer requestProducer,
> AsyncResponseConsumer<T> responseConsumer,
> HttpContext context,
> FutureCallbackIgnorecompelteExcepton <T> callback);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
