[
https://issues.apache.org/jira/browse/HTTPCLIENT-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541433#comment-16541433
]
ASF GitHub Bot commented on HTTPCLIENT-1928:
--------------------------------------------
Github user xiaohu-zhang commented on the issue:
https://github.com/apache/httpcomponents-client/pull/106
thank you
> HttpAsyncClient callback should ignore exception throwed by compelete method
> ----------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1928
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1928
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Reporter: silver9886
> Priority: Major
> Fix For: 5.0 Beta2
>
>
> If exception throwed by completed method in FutureCallback argument in
> HttpAsyncClient.execute，the connection will be closed.
> but the exception throwed by customer code,should not affect the connection
> managed by the framework,the connection should be connected also.
> there can be a class called FutureCallbackIgnorecompelteExcepton class.
> public abstract class FutureCallbackIgnorecompelteExcepton <T> {
> private FutureCallback<T> t;
> void completed(T result){
> try{
> t.completed(result);
> }catch(Exception e)
> //ignore
> }
> void failed(Exception ex);
> void cancelled();
> }
> HttpAsyncClient changed as:
> HttpAsyncClient.<T> Future<T> execute(
> AsyncRequestProducer requestProducer,
> AsyncResponseConsumer<T> responseConsumer,
> HttpContext context,
> FutureCallbackIgnorecompelteExcepton <T> callback);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
