Github user xiaohu-zhang commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
1. testTimeoutInSSecond method in class TestHashedWheelTimer should rename
to testTimeoutInSecond ,I dont have permission to push to your branch.
2.why delete
if (isWindows()) {
- sleepTimeMs = sleepTimeMs / 10 * 10;
- }
in HashedWheelTimer class. the comment is clearly said why use this code
blocks in netty.
3. I agree with you set package private. I dont like HashedWheelTimer being
static too.Because
HashedWheelTimer class is used only in framework,I think we could change
HashedWheelTimer to be
singleton
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
