Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
1. How come? That basically means that a read or write event can get
triggered by an I/O reactor thread concurrently with a timeout event triggered
by the time-wheel thread making it necessary to synchronize **_all_** methods
of the `IOEventHandler` interface. This breaks current `IOEventHandler`
contract and possibly negates all the performance gains from your changes
2. This is theory and it looks promising. But I still would like to see if
it actually produces any performance in real life scenarios, especially in
situations when _every_ channel sets a socket timeout.
I do not think I can accept the change-set in its current state. It can be
accepted if we can solve the concurrency issue and get some empirical evidence
of performance improvement.
Are you at the [email protected] list? If not, please subscribe and let us
discuss further steps on the dev list.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
