Thank you Oleg. I think we can consider this thread closed. Gary
On Sat, Jul 14, 2018 at 4:41 AM Oleg Kalnichevski <ol...@apache.org> wrote: > On Fri, 2018-07-13 at 13:40 -0600, Gary Gregory wrote: > > On Fri, Jul 13, 2018 at 12:24 PM Oleg Kalnichevski <ol...@apache.org> > > wrote: > > > > > On Fri, 2018-07-13 at 10:27 -0600, Gary Gregory wrote: > > > > > > > > > > ... > > > > > > > > > > > This is now in git master but I think I need another tweak: I > > > > made > > > > the > > > > return type for HttpRequests the class HttpUriRequestBase instead > > > > of > > > > an > > > > interface. I left ClassicHttpRequests to return > > > > ClassicHttpRequest > > > > but now > > > > I wonder if it would not be more flexible to make it return > > > > HttpUriRequestBase > > > > as well. Thoughts? > > > > > > > > > > Hi Gary > > > > > > I am sorry it was not quite clear what exactly I had meant. I just > > > wanted to have a similar enum applicable to the async methods that > > > use > > > generic HttpRequest / HttpResponse classes. > > > > > > I tweaked your code slightly. Please have a look. > > > > > > > Hi Oleg, > > > > Looks good. > > > > The remaining question is what should be the return type for > > ClassicHttpRequests.create(URI): ClassicHttpRequest or > > HttpUriRequestBase? > > > > I suppose it should have been HttpUriRequestBase. Corrected. > > > http://git-wip-us.apache.org/repos/asf/httpcomponents-client/commit/0abadca8 > > Oleg > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > For additional commands, e-mail: dev-h...@hc.apache.org > >
