[
https://issues.apache.org/jira/browse/HTTPCORE-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569798#comment-16569798
]
ASF GitHub Bot commented on HTTPCORE-536:
-----------------------------------------
GitHub user clevertension opened a pull request:
https://github.com/apache/httpcomponents-core/pull/72
Fix HTTPCORE-536
Fix HTTPCORE-536
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clevertension/httpcomponents-core master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpcomponents-core/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
----
commit 94aa52bf7aa8a9dbf83925b174bd3a3df5441796
Author: clevertension <zdan0803@...>
Date: 2018-08-06T06:37:31Z
Fix HTTPCORE-536
----
> duplicate connect method could be extract
> -----------------------------------------
>
> Key: HTTPCORE-536
> URL: https://issues.apache.org/jira/browse/HTTPCORE-536
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore NIO
> Reporter: silver9886
> Priority: Major
>
> DefaultConnectingIOReactor and DefaultListeningIOReactor connect method are
> same.
> create abstractDefaultIOReactor class,put the connect code to the abstract
> class.
> AsyncServer and AsyncRequester connect method are same.
> create abstractAsyncServerandRequester class,put the connect code to the
> abstract class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
