[
https://issues.apache.org/jira/browse/HTTPCORE-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569992#comment-16569992
]
ASF GitHub Bot commented on HTTPCORE-536:
-----------------------------------------
Github user clevertension commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/72#discussion_r207837950
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/AsyncRequester.java
---
@@ -132,4 +119,8 @@ public void close() throws IOException {
ioReactor.close();
}
+ @Override
--- End diff --
this method must implement in the AsyncRequester, AsyncServer, because the
AbstractAsyncServerAndRequester should use the IORector to connect, so
change it to **protected** or **friendly**?
> duplicate connect method could be extract
> -----------------------------------------
>
> Key: HTTPCORE-536
> URL: https://issues.apache.org/jira/browse/HTTPCORE-536
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore NIO
> Reporter: silver9886
> Priority: Major
>
> DefaultConnectingIOReactor and DefaultListeningIOReactor connect method are
> same.
> create abstractDefaultIOReactor class,put the connect code to the abstract
> class.
> AsyncServer and AsyncRequester connect method are same.
> create abstractAsyncServerandRequester class,put the connect code to the
> abstract class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
